RF Generation Message Board

Announcements and Feedback => Announcements and Feedback => Topic started by: techwizard on August 27, 2015, 11:39:46 AM



Title: default region filter in search
Post by: techwizard on August 27, 2015, 11:39:46 AM
can this be changed to all countries? it's not an issue when i'm logged in because i can set it in my preferences, but for some reason if you're not logged in the default is Germany every time. occasionally i just want to use the search and don't need to log in, but it gets annoying to need to set the region every search.


Title: Re: default region filter in search
Post by: tactical_nuke on August 27, 2015, 03:46:57 PM
In addition to that, it can mess up first time users who aren't as initiated with the search.


Title: Re: default region filter in search
Post by: techwizard on August 28, 2015, 12:57:16 AM
In addition to that, it can mess up first time users who aren't as initiated with the search.

i didn't think about it past a slight annoyance but you're right, when it comes up with no results for many searches because they aren't german exclusives, that would be discouraging to new users who may not notice the filter.


Title: Re: default region filter in search
Post by: Izret101 on August 28, 2015, 07:52:56 AM
That sounds like something got messed up somewhere. Default should be all regions.


Title: Re: default region filter in search
Post by: Shadow Kisuragi on August 28, 2015, 08:34:14 AM
Took a quick look this morning, and it looks like whatever the default from this statement is causes the problem:

search.pl:
$country_select = &PrintCountrySelect;

<td>Region:
       </td>
       <td align="left">
       <select name="country" size="1" onChange="changeRegionWide(this.value);">
      $country_select
            </select>

I still need to investigate more, but it should be a simple fix once I can track down what that value is getting set by.


Title: Re: default region filter in search
Post by: Shadow Kisuragi on August 28, 2015, 09:10:53 AM
Fixed. And...the site makes me sad again.
We're depending on a fake user, with ID 0, to load settings from, rather than defaulting. That user had Europe (Regionwide), Germany (Country) as default region and country.


Title: Re: default region filter in search
Post by: techwizard on August 28, 2015, 11:16:43 AM
Fixed. And...the site makes me sad again.
We're depending on a fake user, with ID 0, to load settings from, rather than defaulting. That user had Europe (Regionwide), Germany (Country) as default region and country.

well...that's something. at least it's working now though, thanks for the fix!


Title: Re: default region filter in search
Post by: Shadow Kisuragi on August 28, 2015, 11:55:13 AM
Thanks for reporting it!